Update BeanOutputConverter.java #3927
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved the exceptional issue of converting the large model deployed locally with Ollama into a Java Bean. Signed-off-by: James <[email protected]>
markpollack
reviewed
Jul 29, 2025
| @@ -159,6 +159,7 @@ private void generateSchema() { | |||
| @Override | |||
| public T convert(@NonNull String text) { | |||
| try { | |||
| text = text.replaceAll("<think>[\\s\\s]*?</think>","") | |||
There was a problem hiding this comment.
I think we are going to have to opt into this 'exclusion' in the output converter. I'd like to make this a pluggable stragtegy, who knows how many ways the thinking response will be done. is this from anthropic or deepseek?. we have to overhaul the whole code base to handle 'thinking' responses in the assistant messgae, but hacks like this are useful.
also missing semicolon
There was a problem hiding this comment.
Should it be \s and \S here?
Suggested change
| text = text.replaceAll("<think>[\\s\\s]*?</think>","") | |
| text = text.replaceAll("<think>[\\s\\S]*?</think>",""); |
Although this regex is simple, it's better to have unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved the exceptional issue of converting the large model deployed locally with Ollama into a Java Bean.